[PATCH] D111354: [NFC] Including <string> in llvm-cxxdump/Error.cpp

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

In D111354#3050830 <https://reviews.llvm.org/D111354#3050830>, @qiongsiwu1 wrote:

> In D111354#3050388 <https://reviews.llvm.org/D111354#3050388>, @RKSimon wrote:
>
>> @qiongsiwu1 I ran check-llvm on windows, wsl and linux boxes and didn't hit this - does this mean llvm-cxxdump isn't built/tested by default at all?
>
> Thanks for looking into this! `llvm-cxxdump` builds on Linux without explicitly including the header, at least during our testing. For Linux on Power, it happens to work for us due to the build compiler including the header through other means as a side effect (Specifically, the `utility` header including `cstdlib`). The build failed on AIX because the libc++ on the platform not having such side effects.

Thanks for the clarification - the lack of buildbot failures suggested I'd gotten it mostly right - implicit dependencies will always hit in unexpected places of course.....


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111354/new/

https://reviews.llvm.org/D111354