[PATCH] D111395: [flang][driver] Fix erroneous `&`

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 8 02:52:00 PDT 2021


awarzynski created this revision.
Herald added a project: Flang.
awarzynski requested review of this revision.
Herald added subscribers: llvm-commits, jdoerfert.
Herald added a project: LLVM.

As pointed out by Valentin Clement in PR [1], we should be using `&&`
instead of `&`.

[1] https://github.com/flang-compiler/f18-llvm-project/pull/1113#discussion_r724321121


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111395

Files:
  flang/lib/Frontend/FrontendActions.cpp


Index: flang/lib/Frontend/FrontendActions.cpp
===================================================================
--- flang/lib/Frontend/FrontendActions.cpp
+++ flang/lib/Frontend/FrontendActions.cpp
@@ -37,7 +37,7 @@
 }
 
 bool PrescanAndSemaAction::BeginSourceFileAction() {
-  return RunPrescan() & RunParse() && RunSemanticChecks();
+  return RunPrescan() && RunParse() && RunSemanticChecks();
 }
 
 //===----------------------------------------------------------------------===//


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111395.378150.patch
Type: text/x-patch
Size: 485 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211008/3b659610/attachment.bin>


More information about the llvm-commits mailing list