[PATCH] D110167: [Dexter] Add option to pass a Visual Studio solution instead of a binary

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 8 01:27:18 PDT 2021


StephenTozer added a comment.

In D110167#3050365 <https://reviews.llvm.org/D110167#3050365>, @Orlando wrote:

> Do we need both `_loading_error` and `init_success`? I might be missing something but it looks like the property `is_available` (which uses `_loading_error`) currently covers the use case of `init_success`.

Probably not - it basically amounts to keeping state in the Debugger that records //where// we failed rather than just what the error was. With that said, I don't think we really use that at all right now, since error handling is just "Init -> Check for failure -> Setup -> Check for failure", so we could probably do fine without it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110167/new/

https://reviews.llvm.org/D110167



More information about the llvm-commits mailing list