[PATCH] D81803: [Support] PR42623: Avoid setting the delete-on-close bit if a TempFile doesn't reside on a local drive

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 8 01:24:47 PDT 2021


mstorsjo added a comment.

In D81803#3050404 <https://reviews.llvm.org/D81803#3050404>, @jhenderson wrote:

> Having TempFile attempt to manually delete the underlying file seems like a reasonable approach to me.

Thanks! Do you have any opinions on the least bad way of plumbing this signal through from `setDeleteDisposition` in `openNativeFile` down to `TempFile::create`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81803/new/

https://reviews.llvm.org/D81803



More information about the llvm-commits mailing list