[PATCH] D111291: [MIRParser] Add support for IsInlineAsmBrIndirectTarget

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:523
+      os << "inlineasm-br-indirect-target";
+      hasAttributes = true;
+    }
----------------
nickdesaulniers wrote:
> seeing this much duplication makes me think we could DRY up attribute emission. Maybe a helper method would simply codegen here?
We could do something like this to common up the simple attributes, but it doesn't help with attributes like "align" that take a value: https://reviews.llvm.org/differential/diff/378106/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111291/new/

https://reviews.llvm.org/D111291