[llvm] b84d9d2 - [TargetPassConfig] Remove an obsolete FIXME comment

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 7 23:34:30 PDT 2021


Author: Jay Foad
Date: 2021-10-08T07:34:25+01:00
New Revision: b84d9d299ef3e99a88620b18ca91e402a42f5209

URL: https://github.com/llvm/llvm-project/commit/b84d9d299ef3e99a88620b18ca91e402a42f5209
DIFF: https://github.com/llvm/llvm-project/commit/b84d9d299ef3e99a88620b18ca91e402a42f5209.diff

LOG: [TargetPassConfig] Remove an obsolete FIXME comment

The "coloring with register" functionality it refers to was removed ten
years ago in svn r144481 "Remove the -color-ss-with-regs option".

Added: 
    

Modified: 
    llvm/lib/CodeGen/TargetPassConfig.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/TargetPassConfig.cpp b/llvm/lib/CodeGen/TargetPassConfig.cpp
index 9e30c533b54b6..05ebf6a1ffe13 100644
--- a/llvm/lib/CodeGen/TargetPassConfig.cpp
+++ b/llvm/lib/CodeGen/TargetPassConfig.cpp
@@ -1465,9 +1465,6 @@ void TargetPassConfig::addOptimizedRegAlloc() {
 
   if (addRegAssignAndRewriteOptimized()) {
     // Perform stack slot coloring and post-ra machine LICM.
-    //
-    // FIXME: Re-enable coloring with register when it's capable of adding
-    // kill markers.
     addPass(&StackSlotColoringID);
 
     // Allow targets to expand pseudo instructions depending on the choice of


        


More information about the llvm-commits mailing list