[PATCH] D111288: [fir] Add data flow optimization pass

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Drive by: Just glancing at this I am very doubtful this is correct or well tested:

- All non-load/store users are ignored, which is already a bad thing (I just so the FIXME which is easily lost and not mentioned in the rather sparse commit message).
- The reasoning about "nearest stores" ignores all non dominating stores, which should also not be correct.
- The reasoning about "unneeded stores" ignores non-dominated loads, which should also not be correct.
- Given that the test have no comments I'm not sure if they are positive or negative tests. I would hope both are present and the situations described above are in there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111288/new/

https://reviews.llvm.org/D111288