[PATCH] D111343: [x86] Implement a tagged-globals backend feature.

Matt Morehouse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 7 14:50:32 PDT 2021


morehouse updated this revision to Diff 378017.
morehouse added a comment.

- Clarify that -mrelax-relocations=no is required.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111343/new/

https://reviews.llvm.org/D111343

Files:
  llvm/lib/Target/X86/X86.td


Index: llvm/lib/Target/X86/X86.td
===================================================================
--- llvm/lib/Target/X86/X86.td
+++ llvm/lib/Target/X86/X86.td
@@ -378,7 +378,8 @@
     : SubtargetFeature<
           "tagged-globals", "AllowTaggedGlobals", "true",
           "Use an instruction sequence for taking the address of a global "
-          "that allows a memory tag in the upper address bits.">;
+          "that allows a memory tag in the upper address bits. Currently "
+          "also requires -mrelax-relocations=no to work properly.">;
 
 //===----------------------------------------------------------------------===//
 // X86 Subtarget Tuning features


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111343.378017.patch
Type: text/x-patch
Size: 676 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211007/ea0ad8d6/attachment.bin>


More information about the llvm-commits mailing list