[PATCH] D111350: [LoopFlatten] Mark inner loop as deleted
Arthur Eubanks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 7 14:40:34 PDT 2021
aeubanks added a comment.
if we have a loop nest pass in one pass manager delete a loop without invalidating its analyses, then another loop pass in a different pass manager allocate a loop at the same address I think we could still see invalid cached analyses
`LoopAnalysisManagerFunctionProxy::Result::invalidate()` may walk through LoopInfo to get a list of loops to clear analyses, and if we delete a loop, we won't clear the corresponding cached analyses. We can always blow away the entire LoopAnalysisManagerFunctionProxy, but always properly invalidating seems cleaner and there's less chance of things silently going wrong.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111350/new/
https://reviews.llvm.org/D111350
More information about the llvm-commits
mailing list