[PATCH] D111272: [InlineCost] model calls to llvm.is.constant* more carefully

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 7 13:46:47 PDT 2021


nickdesaulniers planned changes to this revision.
nickdesaulniers added a comment.

In D111272#3046672 <https://reviews.llvm.org/D111272#3046672>, @nickdesaulniers wrote:

> - cut test size in half by marking hweight_long internal rather than hidden; we don't care about the leaf function

This had the unintended side effect of giving the callee a significant discount on inline cost `LastCallToStaticBonus`; I should revert that change. Otherwise I suspect the test is green after BUT ALSO BEFORE (bad) this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111272/new/

https://reviews.llvm.org/D111272



More information about the llvm-commits mailing list