[llvm] 097339b - [TargetPassConfig] Enable machine verification after miscellaneous passes

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 7 13:27:53 PDT 2021


Author: Jay Foad
Date: 2021-10-07T21:24:50+01:00
New Revision: 097339b1cadcd6c24b607355db0f4c271d8ed261

URL: https://github.com/llvm/llvm-project/commit/097339b1cadcd6c24b607355db0f4c271d8ed261
DIFF: https://github.com/llvm/llvm-project/commit/097339b1cadcd6c24b607355db0f4c271d8ed261.diff

LOG: [TargetPassConfig] Enable machine verification after miscellaneous passes

In a couple of places machine verification was disabled for no apparent
reason, probably just because an "addPass(..., false)" line was cut and
pasted from elsewhere.

After this patch the only remaining place where machine verification is
disabled in the generic TargetPassConfig code, is after addPreEmitPass.

Added: 
    

Modified: 
    llvm/lib/CodeGen/TargetPassConfig.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/TargetPassConfig.cpp b/llvm/lib/CodeGen/TargetPassConfig.cpp
index b169ce628ce0..9e30c533b54b 100644
--- a/llvm/lib/CodeGen/TargetPassConfig.cpp
+++ b/llvm/lib/CodeGen/TargetPassConfig.cpp
@@ -1217,7 +1217,7 @@ void TargetPassConfig::addMachinePasses() {
   // GC
   if (addGCPasses()) {
     if (PrintGCInfo)
-      addPass(createGCInfoPrinter(dbgs()), false);
+      addPass(createGCInfoPrinter(dbgs()));
   }
 
   // Basic block placement.
@@ -1507,7 +1507,7 @@ void TargetPassConfig::addMachineLateOptimization() {
 
 /// Add standard GC passes.
 bool TargetPassConfig::addGCPasses() {
-  addPass(&GCMachineCodeAnalysisID, false);
+  addPass(&GCMachineCodeAnalysisID);
   return true;
 }
 


        


More information about the llvm-commits mailing list