[PATCH] D111154: [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR

[Thomas Lively via Phabricator via llvm-commits]

tlively added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:821
 
 bool WebAssemblyTargetLowering::getTgtMemIntrinsic(IntrinsicInfo &Info,
                                                    const CallInst &I,
----------------
pmatos wrote:
> tlively wrote:
> > I expect that you'll have to do something here as well.
> I am confused. Is this comment maybe related to D111227 instead?
Oh, actually I think I was confused as well. Disregard this.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyMCInstLower.cpp:77
+      // that is a reference type.
+      // FIXME: the following code can be simplified.
+      if (GlobalVT->isArrayTy() && isRefType(GlobalVT->getArrayElementType())) {
----------------
Do you have ideas for this simplification as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111154/new/

https://reviews.llvm.org/D111154