[PATCH] D110834: [PHIElimination] Account for INLINEASM_BR when inserting kills

Thu Oct 7 11:52:45 PDT 2021

foad added a comment.

In D110834#3042425 <https://reviews.llvm.org/D110834#3042425>, @foad wrote:

> In D110834#3040559 <https://reviews.llvm.org/D110834#3040559>, @MatzeB wrote:
>
>> Please consider changing the test to use a `.mir` file.
>
> I'm having trouble writing a .mir file containing an INLINEASM_BR instruction because the verifier complains: `Bad machine code: MBB has unexpected successors which are not branch targets, fallthrough, EHPads, or inlineasm_br targets.`
>
> It seems like whatever flag gets set on an MBB to say it is an inlineasm_br target does not get serialised in textual MIR. @jyknight does that sound right? Any suggestions for writing MIR test cases?

I fixed that in D111291 <https://reviews.llvm.org/D111291>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110834/new/

https://reviews.llvm.org/D110834