[PATCH] D111116: [RISCV][test] Add tests of (add (shl r, c0), c1)

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 7 11:11:44 PDT 2021


craig.topper added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/shlimm-addimm.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+;; Test that (add (shl x, c1), c2) can be transformed to
+;; (add (shl (add x, c2/c1), c1), c2%c1) or (shl (add x, c2/c1), c1)
----------------
Put this comment below the RUN lines


================
Comment at: llvm/test/CodeGen/RISCV/shlimm-addimm.ll:3
+;; Test that (add (shl x, c1), c2) can be transformed to
+;; (add (shl (add x, c2/c1), c1), c2%c1) or (shl (add x, c2/c1), c1)
+;; if profitable.
----------------
Should this be c2>>c1 instead of c2/c1?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111116/new/

https://reviews.llvm.org/D111116



More information about the llvm-commits mailing list