[PATCH] D110829: [X86] Special-case ADD of two identical registers in convertToThreeAddress

[Matthias Braun via Phabricator via llvm-commits]

MatzeB accepted this revision.
MatzeB added a comment.

Still LGTM



================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:1238
             .add(Src);
+    Copy->getOperand(1).setIsKill(isKill);
 
----------------
foad wrote:
> @MatzeB are you happy with this bit? Your suggested changes didn't go quite far enough to get a "kill" on the inserted COPY.
Yes makes sense.

`.addReg(Src, getKillRegState(isKill))` above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110829/new/

https://reviews.llvm.org/D110829