[PATCH] D111291: [MIRParser] Add support for IsInlineAsmBrIndirectTarget

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 7 10:14:48 PDT 2021


nickdesaulniers added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:523
+      os << "inlineasm-br-indirect-target";
+      hasAttributes = true;
+    }
----------------
seeing this much duplication makes me think we could DRY up attribute emission. Maybe a helper method would simply codegen here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111291/new/

https://reviews.llvm.org/D111291



More information about the llvm-commits mailing list