[PATCH] D111257: [fir] Add affine demotion pass

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 7 09:26:55 PDT 2021


clementval added a comment.

In D111257#3048387 <https://reviews.llvm.org/D111257#3048387>, @mehdi_amini wrote:

>> Do you mean prefixing the class name? I have tried to look at the core MLIR and I don't see a pattern for names of dialects passes.
>
> In general the class names aren't public, I meant the command line options: this is in a global registry and it could just fail at runtime if another library would use the same name.

Ah ok! Makes more sense. Let me check with others and we can probably apply later to make this homogenous.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111257/new/

https://reviews.llvm.org/D111257



More information about the llvm-commits mailing list