[PATCH] D110924: [LoopUtils] Consider unreachable-terminated blocks as deoptimizing

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 7 09:11:04 PDT 2021


reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

This is not a comment on the code, but a comment on the commit message.

"deoptimizing" has a very specific meaning.  An unreachable block is *not* deoptimizing.  Given that, the description on the review makes zero sense.  (As in, without looking at the code, I literally had no idea what you were trying for.)  You need to rework the commit message before this is meaningfully reviewable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110924/new/

https://reviews.llvm.org/D110924



More information about the llvm-commits mailing list