[PATCH] D110557: [X86] Optimize fdiv with reciprocal instructions for half type

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:23231
+
+  if (VT.getScalarType() == MVT::f16 && Subtarget.hasFP16()) {
+    if (RefinementSteps == ReciprocalEstimate::Unspecified)
----------------
craig.topper wrote:
> You need to know the type is legal. v64f16 will get through this, but type legalization won't be able to split a v64f16 X86ISD::RCP14 node.
Yes. Thanks Craig!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110557/new/

https://reviews.llvm.org/D110557