[PATCH] D110502: [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution

Thu Oct 7 07:48:52 PDT 2021

NimishMishra marked an inline comment as done.
NimishMishra added a comment.

In D110502#3034679 <https://reviews.llvm.org/D110502#3034679>, @kiranchandramohan wrote:

> Thanks @NimishMishra for taking this forward. Can you include the parser changes also from https://reviews.llvm.org/D93051?

Thanks for the comment. I analyzed this as well as worked on a few semantic checks related to hint clause. Are we sure that we require this as a clause list? Because everything is working smoothly anyway. In  D93051 <https://reviews.llvm.org/D93051>, parser changes involves changing the optional clause to a list, of which I do not presently understand the requirement.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110502/new/

https://reviews.llvm.org/D110502