[PATCH] D111048: [ARM] Introduce a MQPRCopy

Sam Tebbs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 7 06:59:58 PDT 2021


samtebbs added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:1068
+      LLVM_DEBUG(dbgs() << " Unable to handle live out: " << *MI);
+      VMOVCopies.clear();
       return false;
----------------
dmgreen wrote:
> samtebbs wrote:
> > Does it need to clear the list if it's returning immediately after?
> Yeah, It's a class variable used elsewhere. If we fail to tail predicate we might as well create vorr's, not vmovds for the code that remains.
Ah I thought it was stack-allocated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111048/new/

https://reviews.llvm.org/D111048



More information about the llvm-commits mailing list