[PATCH] D110479: [LV] Record memory widening decisions (NFCI)

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks



================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1520
+
+  // Whether the consecutive loaded/stored addresses are in reverse order.
+  bool Reverse;
----------------
might be good to mention that this also implies `Consecutive`


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1578
 
+  // Return whether the loaded-from / stored-to addresses are consecutive.
+  bool isConsecutive() const { return Consecutive; }
----------------
nit: `///` for doc-comment


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1517
 
+  bool Consecutive;
+  bool Reverse;
----------------
fhahn wrote:
> Should we document both fields?
nit: `///` for doc-comment


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110479/new/

https://reviews.llvm.org/D110479