[PATCH] D101633: [AMDGPU] Set number vgprs used in PS shaders based on input registers actually used

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:743
+      // There are some rare circumstances where InputAddr is non-zero and
+      // InputEna can be set to 0 In this case we default to setting LastEna to
+      // 1
----------------
Missing . between the sentences


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:755-757
       if (Arg.hasAttribute(Attribute::InReg))
         WaveDispatchNumSGPR += NumRegs;
+      else {
----------------
Could you add braces for the if as well?


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:770
+          }
+          PSVGPRCount++;
+        } else {
----------------
Should this be an increment or a `+= NumRegs`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101633/new/

https://reviews.llvm.org/D101633