[PATCH] D110167: [Dexter] Add option to pass a Visual Studio solution instead of a binary

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 7 02:28:02 PDT 2021


Orlando added a comment.

LGTM, just one inline question.



================
Comment at: cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/DebuggerControllerBase.py:24-27
+            if self.debugger.init_success:
+                self._run_debugger_custom()
+            else:
+                raise Exception(self.debugger.loading_error)
----------------
Is this (and the necessity for the new `init_success` attribute) a bug-fix? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110167/new/

https://reviews.llvm.org/D110167



More information about the llvm-commits mailing list