[PATCH] D111095: [fir] Add cfg conversion pass

Thu Oct 7 00:50:55 PDT 2021

clementval marked 2 inline comments as done.
clementval added inline comments.

================
Comment at: flang/lib/Optimizer/Transforms/RewriteLoop.cpp:296
+    if (disableCfgConversion)
+      return;
+
----------------
mehdi_amini wrote:
> schweitz wrote:
> > clementval wrote:
> > > mehdi_amini wrote:
> > > > This actually really seems like this option does not belong here: if someone wants to disable cfg-conversion in the compiler, then the proper plumbing is to have this option on the pass manager **builder** so that the pass does not get added to the pipeline.
> > > Right it makes more sense. Just removed the option. 
> > We'll need a way to enable and disable the passes in the test tools and without having to specify the entire pipeline.
> Which test tools? Ultimately the option will have to be pushed there (in whatever abstraction used to build the pipeline there)
We have a test tool that is similar to `mlir-translate` but for FIR of course. Not upstreamed yet. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111095/new/

https://reviews.llvm.org/D111095