[PATCH] D111268: [lld][test] Fix darwin REQUIRES (NFC)

Keith Smiley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 6 13:42:47 PDT 2021


keith created this revision.
Herald added a reviewer: gkm.
Herald added a project: lld-macho.
Herald added a reviewer: lld-macho.
keith requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Some subprojects like compiler-rt define the `darwin` feature in their
lit config, but lld does not do that, so we need to use the global
system-darwin here instead. This test seems to have drifted from the
actual behavior so I also had to add `/usr/local/lib` here to make it
pass.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111268

Files:
  lld/test/MachO/search-paths-darwin.test


Index: lld/test/MachO/search-paths-darwin.test
===================================================================
--- lld/test/MachO/search-paths-darwin.test
+++ lld/test/MachO/search-paths-darwin.test
@@ -1,5 +1,5 @@
 REQUIRES: x86
-REQUIRES: darwin
+REQUIRES: system-darwin
 
 RUN: mkdir -p %t1 %t2
 
@@ -7,6 +7,7 @@
 CHECK:      Library search paths:
 CHECK-NEXT: [[LDIR]]
 CHECK-NEXT: /usr/lib
+CHECK-NEXT: /usr/local/lib
 CHECK-NEXT: Framework search paths:
 CHECK-NEXT: [[FDIR]]
 CHECK-NEXT: /Library/Frameworks


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111268.377670.patch
Type: text/x-patch
Size: 519 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211006/084a9520/attachment.bin>


More information about the llvm-commits mailing list