[PATCH] D111220: [X86][LV][TTI][Costmodel] LoopVectorizer: don't use `TTI::isLegalMaskedGather()` hook, introduce `TTI::shouldUseMaskedGatherForVectorization()`

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 6 12:19:47 PDT 2021


RKSimon added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/X86/gather-cost.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt -loop-vectorize -mtriple=x86_64-apple-macosx -S -mcpu=corei7-avx -enable-interleaved-mem-accesses=false < %s | FileCheck %s
 target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
----------------
pre-commit the regeneration?


================
Comment at: llvm/test/Transforms/LoopVectorize/X86/gather-cost.ll:18
 ; Make sure we are conservative and don't vectorize it.
 ; CHECK-NOT: x float>
 
----------------
Does this pass with this still here?


================
Comment at: llvm/test/Transforms/LoopVectorize/X86/parallel-loops.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt < %s  -loop-vectorize -force-vector-interleave=1 -force-vector-width=4 -dce -instcombine -S | FileCheck %s
----------------
pre-commit?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111220/new/

https://reviews.llvm.org/D111220



More information about the llvm-commits mailing list