[PATCH] D111237: [TypePromotion] Promote PHI-nodes

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 6 10:54:17 PDT 2021


SjoerdMeijer added a comment.

> Let me know what you think of this approach and whether there might be more appropriate ways to ensure we get a better codegen for issues like this.

Sounds like a good and nice addition to this patch, and seems to be the right place for this kind of thing.

Some first drive-by comments: some comments would be nice, some testing and perf numbers too as this pass was really tricky to get right, and like Dave said, some tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111237/new/

https://reviews.llvm.org/D111237



More information about the llvm-commits mailing list