[PATCH] D111240: [llvm-readelf][docs] Add missing options and details to the help output and the command guide

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 6 10:15:51 PDT 2021


MaskRay added a comment.

LG



================
Comment at: llvm/docs/CommandGuide/llvm-readelf.rst:202
 
+ Ignored for GNU readelf compatibility.
+ 
----------------
You may additionally say that our style is similar to GNU readelf's `-W`.


================
Comment at: llvm/tools/llvm-readobj/Opts.td:50
 def elf_linker_options : FF<"elf-linker-options", "Display the .linker-options section">, Group<grp_elf>;
-defm elf_output_style : Eq<"elf-output-style", "Specify ELF dump style">, Group<grp_elf>;
+defm elf_output_style : Eq<"elf-output-style", "Specify ELF dump style, accepted options are are LLVM and GNU">, Group<grp_elf>;
 def histogram : FF<"histogram", "Display bucket list histogram for hash sections">, Group<grp_elf>;
----------------
are are -> are

In some utilities we use colon to indicate choices, e.g. `Specify ELF dump style: LLVM or GNU`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111240/new/

https://reviews.llvm.org/D111240



More information about the llvm-commits mailing list