[PATCH] D111172: [PS4 UBSAN] Emit ud2 for ubsantrap for the PS4 target.

[Paul Robinson via Phabricator via llvm-commits]

probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

One minor thing and LGTM.



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:538
+  if (Subtarget.getTargetTriple().isPS4CPU())
+    setOperationAction(ISD::UBSANTRAP, MVT::Other, Expand);
 
----------------
I'd prefer
```
if (...isPS4CPU())
  setOperationAction(..., Expand);
else
  setOperationAction(..., Legal);
```
as being a bit clearer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111172/new/

https://reviews.llvm.org/D111172