[PATCH] D111223: [GlobalISel] Pass RegBankSelect to applyMapping

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

The low level implementation details look OK to me.

I guess we need to get some agreement about the high level design: is this a good way of handling newly created instructions and BBs? In particular I wonder if there is some way of handling newly created instructions automatically, without having to call setNextInstruction, but I can't quite see how it would work.



================
Comment at: llvm/lib/CodeGen/GlobalISel/RegBankSelect.cpp:698
   ReversePostOrderTraversal<MachineFunction*> RPOT(&MF);
-  for (MachineBasicBlock *MBB : RPOT) {
+  std::copy(RPOT.begin(), RPOT.end(), std::back_inserter(Worklist));
+  while (!Worklist.empty()) {
----------------
Could just `Worklist.insert(Worklist.end(), ...)`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111223/new/

https://reviews.llvm.org/D111223