[PATCH] D111223: [GlobalISel] Pass RegBankSelect to applyMapping

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:774-776
+  RegBankSelectPass.addBBToWorkQueue(LoopBB);
+  RegBankSelectPass.addBBToWorkQueue(RemainderBB);
+  RegBankSelectPass.addBBToWorkQueue(RestoreExecBB);
----------------
foad wrote:
> Before this patch, how did these new BBs get regbankselected?
RegBankSelect had logic to detect if applyMapping moved an instruction to a new basic block and then continued from there.

The banks for instructions in RemainderBB and RestoreExecBB are set here, so they don’t need to be selected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111223/new/

https://reviews.llvm.org/D111223