[PATCH] D111219: [MachineCopyPropagation] Handle propagation of undef copies

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 6 04:01:51 PDT 2021


foad added a reviewer: MatzeB.
foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/CodeGen/MachineCopyPropagation.cpp:579-580
       MOUse.setIsRenamable(false);
+    if (CopySrc.isUndef())
+      MOUse.setIsUndef(true);
 
----------------
`MOUse.setIsUndef(CopySrc.isUndef())` would be a bit neater, and the same for isRenamable. Dunno if it makes any practical difference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111219/new/

https://reviews.llvm.org/D111219



More information about the llvm-commits mailing list