[PATCH] D111211: [docs] Fix typo and minor text changes in MyFirstTypoFix

[Kinuko Yasuda via Phabricator via llvm-commits]

kinu created this revision.
kinu requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111211

Files:
  llvm/docs/MyFirstTypoFix.rst


Index: llvm/docs/MyFirstTypoFix.rst
===================================================================
--- llvm/docs/MyFirstTypoFix.rst
+++ llvm/docs/MyFirstTypoFix.rst
@@ -265,6 +265,8 @@
 
 Well, that makes sense… and the test output suggests it's looking for
 the old string "call itself" and finding our new message instead.
+Note that more tests may fail in a similar way as new tests are
+added time to time.
 
 Let's fix it by updating the expectation in the test.
 
@@ -272,8 +274,9 @@
 
    $ vi ../clang/test/SemaCXX/warn-infinite-recursion.cpp
 
-Everywhere we see // expected-warning{{call itself}}, let's replace it
-with // expected-warning{{to understand recursion}}.
+Everywhere we see `// expected-warning{{call itself}}` (or something similar
+from the original warning text), let's replace it with
+`// expected-warning{{to understand recursion}}`.
 
 Now we could run **all** the tests again, but this is a slow way to
 iterate on a change! Instead, let's find a way to re-run just the
@@ -289,7 +292,7 @@
 
    $ bin/llvm-lit -v ../clang/test/SemaCXX/warn-infinite-recursion.cpp
 
--  **unit tests** (e.g. ToolingTests/ReplacementText.CanDeleteAllText)
+-  **unit tests** (e.g. ToolingTests/ReplacementTest.CanDeleteAllText)
 
 These are C++ programs that call LLVM functions and verify the results.
 They live in suites like ToolingTests. Re-run like this:
@@ -297,7 +300,7 @@
 .. code:: console
 
    $ ninja ToolingTests && tools/clang/unittests/Tooling/ToolingTests
-   --gtest_filter=ReplacementText.CanDeleteAllText
+   --gtest_filter=ReplacementTest.CanDeleteAllText
 
 
 Commit locally


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111211.377459.patch
Type: text/x-patch
Size: 1618 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211006/351476c9/attachment.bin>