[PATCH] D110908: [NPM] Automatic 'opt' pipeline reducer script.

[Markus Lavin via Phabricator via llvm-commits]

markus added a comment.

Thanks for reviewing!



================
Comment at: llvm/utils/reduce_pipeline.py:45
+parser.add_argument(
+    '--expand-passes',
+    action='store_true',
----------------
aeubanks wrote:
> I think automatically doing this would be a bit simpler, but not a huge deal
I'll negate the option so it is on by default but possible to disable if it breaks for some reason.


================
Comment at: llvm/utils/reduce_pipeline.py:112
+    [lstA, lstB] = pipeline.split(lst, idx)
+    lstA = pipeline.prune(lstA)
+    lstB = pipeline.prune(lstB)
----------------
aeubanks wrote:
> very unlikely that this will matter, but perhaps pruning empty pass managers might cause crashes to go away, checking before pruning would be nice
Agree that seems unlikely but I'll add a second option for disabling the pruning just in case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110908/new/

https://reviews.llvm.org/D110908