[PATCH] D110859: [llvm-profgen] Support symbol list for accurate profile

Tue Oct 5 22:45:13 PDT 2021

wenlei added inline comments.

================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:35

+static cl::opt<bool> PopulateProfileSymbolList(
+    "populate-profile-symbol-list", cl::init(true), cl::Hidden,
----------------
wlei wrote:
> hoy wrote:
> > On the second thought, do we want the default value of `PopulateProfileSymbolList` to be true or false? We probably do not want the list for either CS or non-CS in practice for now.
> I checked that our internal tools make it on by default for non-CS. But we haven't tested for CS profile.
> 
> Or we can make it off for CS util we tested it and then we can turn on?
Leave it default on, but turn it off for CS profile unless explicitly specified sounds good to me.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110859/new/

https://reviews.llvm.org/D110859