[PATCH] D110557: [X86] Optimize fdiv with reciprocal instructions for half type

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 5 18:58:19 PDT 2021


pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:23182
+  if (VT.getScalarType() == MVT::f16 && Subtarget.hasFP16()) {
+    RefinementSteps = 0;
+
----------------
craig.topper wrote:
> Should we keep the user RefinementStep if it isn't ReciprocalEstimate::Unspecified?
Yes, we should respect user RefinementStep here. Thanks Craig.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110557/new/

https://reviews.llvm.org/D110557



More information about the llvm-commits mailing list