[PATCH] D111181: llvm-objcopy][ELF] Don't assume RELA sections are dynamic if they carry the SHF_ALLOC flag
Nick Desaulniers via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 5 18:01:49 PDT 2021
nickdesaulniers added a comment.
Thanks for the patch! Perhaps worth adding a new test to llvm/test/tools/llvm-objcopy/ELF/?
With Diff 377339 applied, I observe failures in the following tests:
Failed Tests (2):
LLVM :: tools/llvm-objcopy/ELF/basic-relocations.test
LLVM :: tools/llvm-objcopy/ELF/no-symbol-relocation.test
`$ llvm-lit -vv llvm/test/tools/llvm-objcopy/ELF/basic-relocations.test llvm/test/tools/llvm-objcopy/ELF/no-symbol-relocation.test`
Perhaps they need to be fixed up in conjunction with this change?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111181/new/
https://reviews.llvm.org/D111181
More information about the llvm-commits
mailing list