[PATCH] D110859: [llvm-profgen] Support symbol list for accurate profile

[Lei Wang via Phabricator via llvm-commits]

wlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:101
 
+void ProfileGenerator::write(std::unique_ptr<SampleProfileWriter> Writer,
+                             SampleProfileMap &ProfileMap) {
----------------
wenlei wrote:
> Looking at the implementation, seems it should work for CS profile too? `Profile.getName()` only gets the leaf name instead of full context name, we just need to deduplicate the leaf name for CS profile. So I'm wondering if we can move it to `ProfileGeneratorBase::write` so it covers both CS and non-CS profile? 
Sounds good, added to support CS profile. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110859/new/

https://reviews.llvm.org/D110859