[PATCH] D110900: Triple: Add RedHat vendor

Tue Oct 5 16:37:13 PDT 2021

aaronpuchert added a comment.

In D110900#3044136 <https://reviews.llvm.org/D110900#3044136>, @hvdijk wrote:

> In D110900#3043521 <https://reviews.llvm.org/D110900#3043521>, @tstellar wrote:
>
>> 
>
> Ah, okay, but that is how LLVM behaves today as well, is it not? LLVM can either be configured for x86_64-redhat-linux, in which case it will not be seen as a GNU environment, or it can be configured for x86_64-redhat-linux-gnu, in which case the x86_64-redhat-linux installation will be found but will not be preferred.

Can't speak for RedHat, but on SUSE we have

  > gcc -dumpmachine
  x86_64-suse-linux
  > clang -dumpmachine
  x86_64-unknown-linux-gnu

and that I think is the problem for `config.guess`. (RedHat is probably similar, since before this change there is no vendor for it at all.)

> A possibly radical alternative suggestion: could we instead change the way the GCC installation to use is determined?

Some kind of map from `llvm::Triple` to a path/directory for the GCC installation? Should be feasible, but it wouldn't harmonize the `-dumpmachine` output.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110900/new/

https://reviews.llvm.org/D110900