[PATCH] D109504: [WIP] [Intrinsics] Introduce memcmp intrinsics.

Artur Pilipenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 5 16:21:38 PDT 2021


apilipenko added a comment.

Since this is a change to LangRef, please, post the proposal to llvm-dev.

In general this intrinsic looks reasonable and fits well with other libc intrinsics. One thing to think about is how to handle this intrinsic in the optimizer. Looks like there are plenty of places where the optimizer knows to recognize memcmp as a known libc function. For example, there are quite a few simplifications in LibCallSimplifier::optimizeMemCmp. Grep by "LibFunc_memcmp" to see other places. Do we want to canonicalize memcmp calls to the new intrinsic and teach every place to handle the intrinsic? This would make sense because we would also handle the new element atomic memcmp version this way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109504/new/

https://reviews.llvm.org/D109504



More information about the llvm-commits mailing list