[PATCH] D111086: [WebAssembly] Remove WasmTagType

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 5 16:14:16 PDT 2021


aheejin marked an inline comment as done.
aheejin added inline comments.


================
Comment at: llvm/lib/Object/WasmObjectFile.cpp:1123
       NumImportedTags++;
-      Im.Tag.Attribute = readUint8(Ctx);
-      Im.Tag.SigIndex = readVarint32(Ctx);
+      Im.SigIndex = readVaruint32(Ctx);
       break;
----------------
tlively wrote:
> Would it be possible to validate that the signature is within bounds here? I notice the function signatures are not check either, so my guess is that it is not possible to check.
I think it's possible. Did that both for functions and tags.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111086/new/

https://reviews.llvm.org/D111086



More information about the llvm-commits mailing list