[PATCH] D110885: [NFC][AttributeList] Replace index_begin/end with an iterator

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 5 15:25:56 PDT 2021


rnk added a comment.

I had another idle thought on this matter: The unsigned overflow here really isn't that weird. It's the same thing as iterating over the range [-1, 0, `#args+1`]. We could update all these APIs to traffic in plain signed ints, and then there would be no wrapping, just normal index math.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110885/new/

https://reviews.llvm.org/D110885



More information about the llvm-commits mailing list