[PATCH] D111155: [fir] Add affine promotion pass

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 5 11:53:50 PDT 2021


clementval added a comment.

In D111155#3043586 <https://reviews.llvm.org/D111155#3043586>, @awarzynski wrote:

> In D111155#3043512 <https://reviews.llvm.org/D111155#3043512>, @clementval wrote:
>
>> In D111155#3043356 <https://reviews.llvm.org/D111155#3043356>, @awarzynski wrote:
>>
>>> Could you add a test for `affine.if`? How about some negative tests - not mission critical, just nice-to-have.
>>
>> I'm not sure what you have in mind for negative test in a transformation?
>
> E.g. a test with a `fir.do_loop` that should not be transformed and indeed isn't.

Ok. Yeah I can add some.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111155/new/

https://reviews.llvm.org/D111155



More information about the llvm-commits mailing list