[PATCH] D111171: [lld][WebAssembly] Create optional internal symbols only after LTO object as been added

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 5 11:51:34 PDT 2021


sbc100 added a comment.

As I mentioned in https://github.com/emscripten-core/emscripten/issues/12489 I'm having trouble reproducing this and thus creating a test for it.

The problem is that in all the tests I've managed to create all the TLS variables get lowered away by https://github.com/llvm/llvm-project/blob/f92961d238efdfeccce27f9bb7b0a6629c376d4a/llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp#L295.. and therefore `WebAssemblyTargetLowering::LowerGlobalTLSAddress` is never called.. and AFAICT that is the only reasonable place that those references to `__tls_base` could be created during LTO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111171/new/

https://reviews.llvm.org/D111171



More information about the llvm-commits mailing list