[PATCH] D111086: [WebAssembly] Remove WasmTagType

Tue Oct 5 11:24:17 PDT 2021

tlively accepted this revision.
tlively added a comment.
This revision is now accepted and ready to land.

Nice! This looks like a good simplification and matching how function signatures work seems like a good idea.

================
Comment at: llvm/lib/Object/WasmObjectFile.cpp:1123
       NumImportedTags++;
-      Im.Tag.Attribute = readUint8(Ctx);
-      Im.Tag.SigIndex = readVarint32(Ctx);
+      Im.SigIndex = readVaruint32(Ctx);
       break;
----------------
Would it be possible to validate that the signature is within bounds here? I notice the function signatures are not check either, so my guess is that it is not possible to check.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111086/new/

https://reviews.llvm.org/D111086