[PATCH] D111024: [TTI] Remove default condition type and predicate arguments from getCmpSelInstrCost

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

Yes I'd like to add test coverage for this - we're in the weird position that we don't have good checking in the cost models for different predicates, but its difficult to test this for without feeding accurate predicates to the cost models....

The X86 model is getting better at handling costs for different predicates - what I might do is make its costs for BAD_ICMP_PREDICATE/BAD_FCMP_PREDICATE have a much higher/worstcase default cost and work back from there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111024/new/

https://reviews.llvm.org/D111024