[PATCH] D110557: [X86] Optimize fdiv with reciprocal instructions for half type

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:23182
+  if (VT.getScalarType() == MVT::f16 && Subtarget.hasFP16()) {
+    RefinementSteps = 0;
+
----------------
Should we keep the user RefinementStep if it isn't ReciprocalEstimate::Unspecified?


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:23231
+  if (VT.getScalarType() == MVT::f16 && Subtarget.hasFP16()) {
+    RefinementSteps = 0;
+
----------------
Same question as above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110557/new/

https://reviews.llvm.org/D110557