[PATCH] D111150: [AMDGPU] Remove dead frame indices after sgpr spill.

[Christudasan Devadasan via Phabricator via llvm-commits]

cdevadas added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp:459
 
+  for (auto DFI : DeadFrameIndices)
+    SGPRToVGPRSpills.erase(DFI);
----------------
Isn't it possible to avoid this loop by handling the erase inside the original loop itself?
Maybe convert the range-based loop above into an iterator-based one?


================
Comment at: llvm/test/CodeGen/AMDGPU/sgpr-spill-incorrect-fi-bookkeeping-bug.ll:11
+entry:
+  %0 = load i64, i64 addrspace(4)* undef, align 8
+  %1 = inttoptr i64 %0 to i8*
----------------
Can you avoid all the unnamed variables?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111150/new/

https://reviews.llvm.org/D111150