[PATCH] D111062: [RISCV] Rename some assembler mnemonic and intrinsic functions for RVV 1.0.

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added a comment.

LGTM in general. My comments are all about comments. I know the old names are kept as aliases but I still think it's better to reference the "real" instructions where we can.



================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2468
     //  pseudoinstruction: vmsge{u}.vx vd, va, x, v0.t, vt
     //  expansion: vmslt{u}.vx vt, va, x;  vmandnot.mm vd, vd, vt
     assert(Inst.getOperand(0).getReg() == RISCV::V0 &&
----------------
Comment here


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2486
     // pseudoinstruction: vmsge{u}.vx vd, va, x, v0.t, vt
     // expansion: vmslt{u}.vx vt, va, x; vmandnot.mm vt, v0, vt; vmandnot.mm vd,
     // vd, v0; vmor.mm vd, vt, vd
----------------
Comment here too


================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:896
       // If the MaskedOff value and the Mask are the same value use
       // vmslt{u}.vx vt, va, x;  vmandnot.mm vd, vd, vt
       // This avoids needing to copy v0 to vd before starting the next sequence.
----------------
Comment needs updating


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4167
   case ISD::VP_REDUCE_AND: {
     // vpopc ~x == 0
     SDValue TrueMask = DAG.getNode(RISCVISD::VMSET_VL, DL, ContainerVT, VL);
----------------
Comment needs updating here and below


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4201
   // Note that we must return the start value when no elements are operated
   // upon. The vpopc instructions we've emitted in each case above will return
   // 0 for an inactive vector, and so we've already received the neutral value:
----------------
Stale mnemonic name here


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.h:266
 
   //  vpopc.m with additional mask and VL operands.
+  VCPOP_VL,
----------------
Nit: comment needs updating too


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111062/new/

https://reviews.llvm.org/D111062